Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Download Folder Chooser #207

Merged
merged 2 commits into from
Mar 28, 2021

Conversation

Araxeus
Copy link
Collaborator

@Araxeus Araxeus commented Mar 26, 2021

Works flawlessly but :

  • As of now downloadsFolder() from download-folder throws an error and I don't think its from my side (tried alot of things, and all the other modules work)

EDIT: One day later. it suddenly works now, apparently was an error on their end

Error Code for downloadsFolder()

Error:
Error: Module did not self-register: '\\?\c:\youtube-music\node_modules\registry-js\build\Release\registry.node'.
at process.func [as dlopen] (electron/js2c/asar_bundle.js:5:1812)
at Object.Module._extensions..node (internal/modules/cjs/loader.js:1203:18)
at Object.func [as .node] (electron/js2c/asar_bundle.js:5:1812)
at Module.load (internal/modules/cjs/loader.js:992:32)
at Module._load (internal/modules/cjs/loader.js:885:14)
at Function.f._load (electron/js2c/asar_bundle.js:5:12738)
at Module.require (internal/modules/cjs/loader.js:1032:19)
at require (internal/modules/cjs/helpers.js:72:18)
at Object.<anonymous> (c:\Users\Araxeus\git\youtube-music\node_modules\registry-js\dist\lib\registry.js:5:7)
at Module._compile (internal/modules/cjs/loader.js:1152:30)

@semvis123
Copy link
Contributor

Just a quick question, do you get downloaded songs with double lengths as described in #151
Or is this a macOS issue?

@Araxeus
Copy link
Collaborator Author

Araxeus commented Mar 26, 2021

@semvis123 length is ok on windows with latest build

Copy link
Owner

@th-ch th-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the contribution! ✅

@th-ch th-ch merged commit 2b8ba02 into th-ch:master Mar 28, 2021
@Araxeus Araxeus deleted the Download-Plugin-Directory-Chooser branch April 1, 2021 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants