Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove 'shortcuts' from default plugins #218

Merged
merged 1 commit into from
Apr 2, 2021
Merged

remove 'shortcuts' from default plugins #218

merged 1 commit into from
Apr 2, 2021

Conversation

Araxeus
Copy link
Collaborator

@Araxeus Araxeus commented Apr 1, 2021 •
edited
Loading

Resolve #204 , Resolve #50
shortcuts plugin currently blocks more features than it adds, so it probably shouldn't be enabled by default

  • shortcuts block native MediaSession OS integration
  • The media keys [buttons] controls works natively - without the plugin

@Araxeus Araxeus changed the title remove 'shortcuts' + 'discord' from default plugins remove 'shortcuts' from default plugins Apr 1, 2021
th-ch
th-ch approved these changes Apr 2, 2021
View reviewed changes
Copy link
Owner

@th-ch th-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@th-ch th-ch merged commit 8c9e37f into th-ch:master Apr 2, 2021
@Araxeus Araxeus deleted the remove-shortcuts-from-default-plugins branch April 6, 2021 18:45
@Araxeus Araxeus mentioned this pull request Apr 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@th-ch th-ch th-ch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

shortcuts plugin blocks native MediaSession api Display current song in volume bar
2 participants
@Araxeus @th-ch