Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tuna plugin for obs #397

Merged
merged 1 commit into from
Sep 12, 2021
Merged

add tuna plugin for obs #397

merged 1 commit into from
Sep 12, 2021

Conversation

mesmerx
Copy link
Contributor

@mesmerx mesmerx commented Sep 9, 2021

this PR adds a plugin for tuna obs plugin :)

@mesmerx mesmerx mentioned this pull request Sep 9, 2021
Closed
th-ch
th-ch approved these changes Sep 12, 2021
View reviewed changes
Copy link
Owner

@th-ch th-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff looks good, thanks for the contribution! ✅

plugins/tuna-obs/back.js

registerCallback((songInfo) => {

// Register the calilback
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

Suggested change
// Register the calilback
// Register the callback

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry about the typo, it's a "i" from vim that missed

@th-ch th-ch merged commit e3e0775 into th-ch:master Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@th-ch th-ch th-ch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mesmerx @th-ch