Video Toggle Plugin

[Araxeus]

Resolves #392 , Resolves #149

Adds a button that allow switching between video and "song" mode (show thumbnail instead of video)

forceHide in options makes this plugin behave like the old hide-video-player (hide the whole main panel)

Screenshots of the button in action:

Also refined some plugin's description

[th-ch]

Looks good overall, but when the video toggle is enabled ("song" mode), I get TypeError: Only absolute URLs are supported in

youtube-music/providers/song-info.js

Line 14 in 713e005

const getImage = async (src) => {

(src is undefined - possibly linked to the video being overridden?)

[th-ch]

nit: we could add a migration so that people who had the old plugin enabled have this one enabled in the new version.

[Araxeus]

Looks good overall, but when the video toggle is enabled ("song" mode), I get TypeError: Only absolute URLs are supported in

youtube-music/providers/song-info.js

Line 14 in 713e005

const getImage = async (src) => {

(src is undefined - possibly linked to the video being overridden?)

How are you getting an error in song-info? This plugin doesn't even use it nor change any of its data 😵

Where is it originating from? Did that happen in every song or just a few?

@th-ch I cannot reproduce this. could you please check what happened?

my guess is either u tested the wrong branch, or there are some songs which data?.videoDetails?.thumbnail?.thumbnails?.pop()?.url isn't valid for (in that case I would love an example)

anyways I don't think that problem is actually related to this PR but I'd love to know how did it happen

[Araxeus]

Ok I think I figured this one out too. you were playing a video with low resolution of artworks and so when it calls thumbnails.pop() it actually removes the last thumbnail...

[th-ch]

Looks good! ✅ - I cannot reproduce the src bug anymore so it looks fixed 🎉

[Araxeus]

@th-ch Oh I forgot to add , { once: true, passive: true } to the apiloaded listener

could you add that in please? :)

[th-ch]

Sure! The listener has been fixed in cee2e06 and the plugin migration done in 953d6fe :)