-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix playback speed plugin #462
Conversation
add66b4
to
754eac6
Compare
20429d5
to
9bd089a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mousewheel works fine but when clicking directly on the slider, the value updates in the UI but the playback rate is not changed anymore, is it expected?
@th-ch Did you get any errors thrown? can you add some logging to see where does it get stuck? in: youtube-music/plugins/playback-speed/front.js Lines 51 to 56 in 6243e6f
Sadly I can't really do much without more info, since I cant reproduce this |
@th-ch I figured it out - 'immediate-value-change' is a polymer event which only fire on drag, not click. so I had to add a 'd' on there and use 'immediate-value-changed' Except that event doesn't bubble up apparently so I had to set it up straight on the slider, which required waiting for its first load to find it in the dom. anyways it should be fixed now with 41285ac ps. the polymer elements docs link is weird, the url change and if you refresh you lose almost all the documentation :| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed it now works fine on my side with both click and mousewheel 🎉
Looks good, thanks for the improvement! ✅
Fixes memory leaks from observer within observer and unnecessary observers watching the whole document
see Audio compressor plugin #288 (review)
This also normalize the steps of the slider to be 0.125 (1/8)
see here all available levels obtained by dragging the bar:
This also adds a mousewheel listener to the playback speed bar, which allows more precise tuning of the current speed - 0.07 up to 16, in increments of 0.01 (good luck getting to 16 lol)