Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aligned lyric design #510

Merged
merged 2 commits into from
Dec 10, 2021
Merged

Aligned lyric design #510

merged 2 commits into from
Dec 10, 2021

Conversation

MiepHD
Copy link
Contributor

@MiepHD MiepHD commented Dec 4, 2021

I aligned the lyric to the normal lyrics so that the lyric isn't that tiny.

I aligned the lyric to the normal lyrics so that the lyric isn't that tiny
@Araxeus
Copy link
Collaborator

Araxeus commented Dec 4, 2021

Can't you just do font-size: medium; ? is that actually smaller than 14px for you? (thats what initial is on my pc anyways, and slightly bigger than 14px)

also those lines are not needed here, don't really see why you added them

.style-scope ytmusic-tab-renderer {
	display: block;
}

@MiepHD
Copy link
Contributor Author

MiepHD commented Dec 4, 2021

The original looks like that for me:
image
When I add display:block; it looks like:
image
And when adding font-size:14px; it looks how it should:
image
The LyricFind lyrics have font-size 14px

@Araxeus
Copy link
Collaborator

Araxeus commented Dec 5, 2021

Funny thing is that on my pc (1440p monitor), 14px is actually smaller than 'medium' and it looks really tiny, can't even read it at all

Can you try using one of those sizes?

/* <absolute-size> values */
font-size: xx-small;
font-size: x-small;
font-size: small;
font-size: medium;
font-size: large;
font-size: x-large;
font-size: xx-large;
font-size: xxx-large;

Also this display-block is not needed like I said, for 2 reasons:

  1. The lyrics actually looks better when centered (especially on smaller window sizes)
  2. Your current selector .style-scope ytmusic-tab-renderer selects other elements which are not the lyrics tab (its not a unique selector)

@Araxeus
Copy link
Collaborator

Araxeus commented Dec 5, 2021

The viewport size works perfectly 👌🏼

Copy link
Owner

@th-ch th-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the fix! ✅

@th-ch th-ch merged commit 5483f0e into th-ch:master Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants