allow downloading playlists from popup menu #549
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧿 fix #516 , fix #432, fix #190
Allows downloading playlist from the popup menu (previously the button was shown buy didn't work as intended)
The following is the basic way it works:
it also removes the button when the popup menu is opened from an artist page header's (since there is nothing to download)
youtube-music/plugins/downloader/front.js
Lines 23 to 25 in 21c149e
🧿 update ytdl-core (many improvements including way faster download speed), fix #492
🧿 fix playback-speed slider showing up on popup menu's it shouldn't show in (c7e793b)
Screenshots of fixed playlist download buttons in the popup menu (Click to reveal)
in playlist page header
in playlist square renderer
in artist page