Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow downloading playlists from popup menu #549

Merged
merged 4 commits into from
Jan 16, 2022

Conversation

Araxeus
Copy link
Collaborator

@Araxeus Araxeus commented Jan 11, 2022

🧿 fix #516 , fix #432, fix #190

Allows downloading playlist from the popup menu (previously the button was shown buy didn't work as intended)

The following is the basic way it works:

global.download = () => { 
    let videoUrl = getSongMenu().....href
    ...
    if (videoUrl.includes('?playlist=')) {
		ipcRenderer.send('download-playlist-request', videoUrl);
		return;
	}
]

it also removes the button when the popup menu is opened from an artist page header's (since there is nothing to download)

if (menuUrl && !menuUrl.includes('watch?')) return;
menu.prepend(downloadButton);

Note: INVALID_PLAYLIST_MODIFIER = 'RDAMPL' is an invalid modifier that shows up when getting playlist id from the popup-menu of a playlist page (in that case the first button is radio and this modifier is inserted into the id)

🧿 update ytdl-core (many improvements including way faster download speed), fix #492

🧿 fix playback-speed slider showing up on popup menu's it shouldn't show in (c7e793b)

Screenshots of fixed playlist download buttons in the popup menu (Click to reveal)

NOTE: the playback speed slider is showing up when it shouldn't in those screenshots but was also fixed afterwards in c7e793

in playlist page header

image

in playlist square renderer

image

in artist page

image

@Araxeus Araxeus force-pushed the fix-download-button-on-playlist-menu branch from 5f7521b to 21c149e Compare January 11, 2022 20:55
Copy link
Owner

@th-ch th-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the fix! ✅

@th-ch th-ch merged commit a0f2233 into th-ch:master Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants