fix precise-volume hud positioning #567
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was needed for 2 reasons:
srcChanged
event:youtube-music/plugins/video-toggle/front.js
Line 43 in 89ea66b
the following code was supposed to position the hud, but
video.clientHeight
was 0 (because it wasn't updated yet)youtube-music/plugins/video-toggle/front.js
Line 96 in 89ea66b
fixed by setting a tiny delay (250ms) before changing the hud position
the active hud positioning was only inside the video-toggle plugin, so I moved it to the precise-volume plugin.
now if video-toggle is enabled - it will handle all hud positioning, and if it isn't, then precise-volume will handle it itself