Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add single instance lock option #578

Merged
merged 1 commit into from
Feb 9, 2022
Merged

add single instance lock option #578

merged 1 commit into from
Feb 9, 2022

Conversation

Araxeus
Copy link
Collaborator

@Araxeus Araxeus commented Jan 27, 2022 •
edited
Loading

resolves #576

@Araxeus Araxeus mentioned this pull request Jan 27, 2022
Closed
@Araxeus
Copy link
Collaborator Author

Araxeus commented Jan 27, 2022 •
edited
Loading

the menu checkbox label "Single instance lock" could be replace with "Single instance mode" or "Allow only one instance" or something similar

@Araxeus Araxeus mentioned this pull request Feb 7, 2022
Merged
@bkanuka
Copy link

bkanuka commented Feb 9, 2022

🙏 @th-ch

th-ch
th-ch approved these changes Feb 9, 2022
View reviewed changes
Copy link
Owner

@th-ch th-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the option! ✅

@th-ch th-ch merged commit ed15ee9 into th-ch:master Feb 9, 2022
@Araxeus
Copy link
Collaborator Author

Araxeus commented Feb 10, 2022

@th-ch merge conflict with #561
config.set("options.singleInstanceLock", item.checked);
needs to be renamed to
config.setMenuOption

th-ch added a commit that referenced this pull request Feb 13, 2022
@th-ch
Fix #578 (comment)
f865dfd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@th-ch th-ch th-ch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show window if app already running
3 participants
@Araxeus @bkanuka @th-ch