New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[precise-volume] fix expand-volume-slider not updating its value #670

Merged

th-ch merged 1 commit into th-ch:master from Araxeus:fix-precise-volume-not-updating-expand-slider

Apr 7, 2022

Collaborator

Araxeus commented Apr 6, 2022

#expand-volume-slider wasn't getting updated when volume programmatically changed
fix #669

notes:

no changes needed in setupSliderObserver() because manually moving the #expand-volume-slider automatically update the main #volume-slider which triggers the observer
showVolumeSlider() wasn't updated because it would look weird and I see no point in automatically expanding it,


          [precise-volume] fix expand-volume-slider not updating its value

f9cf12b

Araxeus mentioned this pull request

Precise volume doesn't update the slider if it is hidden #669

Closed

th-ch approved these changes

View reviewed changes

Owner

th-ch left a comment

Looks good, thanks for the fix! ✅

th-ch merged commit f98e4ea into th-ch:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet