Fix two sensor graph footer issues #111
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:![image](https://private-user-images.githubusercontent.com/7350294/372570477-bf75fc27-d27c-4e95-9555-33418c373dc6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1MDg4NTYsIm5iZiI6MTczOTUwODU1NiwicGF0aCI6Ii83MzUwMjk0LzM3MjU3MDQ3Ny1iZjc1ZmMyNy1kMjdjLTRlOTUtOTU1NS0zMzQxOGMzNzNkYzYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTRUMDQ0OTE2WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NDA0M2RkY2JmNTY4NzUwMjc0MzFlNTY5ZmU5MmU2MWRlYTQ2ODYxYzc3NTkyODkzMzNlYmUyZjBhMWNhYmY5MyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.hWIr8Oz-5xYlDvMEb9eYRH43wzO2X0d-j902jBY9a3k)
![image](https://private-user-images.githubusercontent.com/7350294/372579325-4a485d3a-09ef-4ac1-af5c-650e93736315.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1MDg4NTYsIm5iZiI6MTczOTUwODU1NiwicGF0aCI6Ii83MzUwMjk0LzM3MjU3OTMyNS00YTQ4NWQzYS0wOWVmLTRhYzEtYWY1Yy02NTBlOTM3MzYzMTUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTRUMDQ0OTE2WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NTBlOTMzZTNiYjU5NDYxZTY5ZjBjMmJjNTQxNTNkM2VkMTBlYzg3YTVjMmZjZmE3MGI0MzdmOTBkN2UyYjU1YSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.TTJ8UhkruCkfEskRmCwzwAdTtVby8MG6TIxf7u3zdFE)
After:
open
) footer isn't full width, there is a gap between the.info
and.footer
elements that gets filled with thebackground-color
(which is also what determines the inner-color color, so we can't just set it toblack
).overflow: hidden
to clip the graph to the black region.I originally discovered the first issue by creating a horizontal stack of two sensors at the end of a vertical stack. I noticed the second issue while investigating the first.
I may have put these rules in a more specific rule than would be ideal, but as far as I know this is the only situation with this issue. Graphs as headers have completely different brokenness that I'm less interested in personally investigating.
Test case: