Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix set insets if the new insets changed #105

Merged
merged 1 commit into from
Jun 14, 2020
Merged

Fix set insets if the new insets changed #105

merged 1 commit into from
Jun 14, 2020

Conversation

ahce
Copy link

@ahce ahce commented Jun 13, 2020

Summary

On Android when keyboard is opened useSafeAreaInsets dispatch a re-render but the insets haven't changed.

This fix prevent unnecessary re-renders.

Test Plan

janicduplessis
janicduplessis approved these changes Jun 14, 2020
View reviewed changes
Copy link
Member

@janicduplessis janicduplessis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think ideally we'd use 2 different callbacks for frame and insets but this is fine for now.

@janicduplessis janicduplessis merged commit 3789f37 into th3rdwave:master Jun 14, 2020
@janicduplessis janicduplessis mentioned this pull request Jun 14, 2020
Closed
@dependabot dependabot bot mentioned this pull request Mar 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janicduplessis janicduplessis janicduplessis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahce @janicduplessis