Added forward Ref to withSafeAreaInsets #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The forward ref is necessary in case the component underneath uses it.
This PR is related to the issue #108
Test Plan
I added the forwardRef to the withSafeAreaInsets, I'm not very experienced with typescript, I tried to implement the correct typing to allow to forward the ref, It should work even if you the component does not pass a ref, ref can be null, I think this typing allows it but I'm not really sure.
I had trouble running the example, as it run but entered in a loop and crashed, even before adding the forwardRef.
I did test It with the patch I included in the issue tracker before.