Margin mode #85
Merged
Margin mode #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it would be nice to make android apply insets the same way as ios when it is not touching edges. But that's for another time :) Is this ready to review? |
|
Just pushed the Android implementation and updated the PR description |
|
If we go this route, I just realised the fallback on iOS 10 would need updating to just use the parent view controller's insets. Will update tomorrow |
janicduplessis
approved these changes
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#50 Summary
Adding margin mode to safe area view
I noticed while doing this that a view's safe area is impacted by the position of itself. If you set a margin, the safe area gets decreased, so you get an infinite loop.
To work around this, I use the parent view controller's view's safe area (i.e. a modal, stack navigation controller, or root view controller). I removed the logic from Android that mimicked iOS's behaviour so they're now hopefully the same.
I'm hoping this change will make it match closer to v1 SafeAreaView, but I'm not sure if this will cause other issues - what do you think?
Note - I looked briefly border modes too - but they use floats instead of yoga values, so made it much more complicated to implement
Test Plan
We have a new playground