Skip to content

Commit

Permalink
Dockerfile: update ALPINE_VERSION to 3.18
Browse files Browse the repository at this point in the history
This also moves `musl-dev` to the alpine-base stage, due to changes in
Alpine 3.18 causing gotestsum build to fail because stdlib.h was missing;

    docker#17 5.065 # runtime/cgo
    docker#17 5.065 In file included from _cgo_export.c:3:
    docker#17 5.065 /usr/include/fortify/stdlib.h:23:15: fatal error: stdlib.h: No such file or directory
    docker#17 5.065    23 | #include_next <stdlib.h>
    docker#17 5.065       |               ^~~~~~~~~~

alpine 3.17:

    / # find / | grep stdlib.h
    /usr/include/c++/12.2.1/tr1/stdlib.h
    /usr/include/c++/12.2.1/stdlib.h

alpine 3.18

    / # find / | grep stdlib.h
    /usr/lib/llvm16/lib/clang/16/include/__clang_hip_stdlib.h
    /usr/include/fortify/stdlib.h
    /usr/include/c++/12.2.1/tr1/stdlib.h
    /usr/include/c++/12.2.1/stdlib.h

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
  • Loading branch information
thaJeztah authored and pull[bot] committed Mar 18, 2024
1 parent b63a0b1 commit f238f1e
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# syntax=docker/dockerfile:1

ARG BASE_VARIANT=alpine
ARG ALPINE_VERSION=3.17
ARG ALPINE_VERSION=3.18
ARG BASE_DEBIAN_DISTRO=bookworm

ARG GO_VERSION=1.21.3
Expand Down
2 changes: 1 addition & 1 deletion dockerfiles/Dockerfile.authors
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# syntax=docker/dockerfile:1

ARG ALPINE_VERSION=3.17
ARG ALPINE_VERSION=3.18

FROM alpine:${ALPINE_VERSION} AS gen
RUN apk add --no-cache bash git
Expand Down
2 changes: 1 addition & 1 deletion dockerfiles/Dockerfile.dev
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# syntax=docker/dockerfile:1

ARG GO_VERSION=1.21.3
ARG ALPINE_VERSION=3.17
ARG ALPINE_VERSION=3.18

ARG BUILDX_VERSION=0.12.0
FROM docker/buildx-bin:${BUILDX_VERSION} AS buildx
Expand Down
2 changes: 1 addition & 1 deletion dockerfiles/Dockerfile.lint
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# syntax=docker/dockerfile:1

ARG GO_VERSION=1.21.3
ARG ALPINE_VERSION=3.17
ARG ALPINE_VERSION=3.18
ARG GOLANGCI_LINT_VERSION=v1.55.2

FROM golangci/golangci-lint:${GOLANGCI_LINT_VERSION}-alpine AS golangci-lint
Expand Down
2 changes: 1 addition & 1 deletion dockerfiles/Dockerfile.vendor
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# syntax=docker/dockerfile:1

ARG GO_VERSION=1.21.3
ARG ALPINE_VERSION=3.17
ARG ALPINE_VERSION=3.18
ARG MODOUTDATED_VERSION=v0.8.0

FROM golang:${GO_VERSION}-alpine${ALPINE_VERSION} AS base
Expand Down

0 comments on commit f238f1e

Please sign in to comment.