Skip to content

Commit

Permalink
TestIpcModeOlderClient: skip if client < 1.40
Browse files Browse the repository at this point in the history
This test case requires not just daemon >= 1.40, but also
client API >= 1.40. In case older client is used, we'll
get failure from the very first check:

> ipcmode_linux_test.go:313: assertion failed: shareable (string) != private (string)

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
  • Loading branch information
kolyshkin committed Apr 26, 2019
1 parent 83ac2b4 commit 1ada1c8
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion integration/container/ipcmode_linux_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -300,12 +300,14 @@ func TestDaemonIpcModeShareableFromConfig(t *testing.T) {
// by default, even when the daemon default is private.
func TestIpcModeOlderClient(t *testing.T) {
skip.If(t, versions.LessThan(testEnv.DaemonAPIVersion(), "1.40"), "requires a daemon with DefaultIpcMode: private")
c := testEnv.APIClient()
skip.If(t, versions.LessThan(c.ClientVersion(), "1.40"), "requires client API >= 1.40")

t.Parallel()

ctx := context.Background()

// pre-check: default ipc mode in daemon is private
c := testEnv.APIClient()
cID := container.Create(t, ctx, c, container.WithAutoRemove)

inspect, err := c.ContainerInspect(ctx, cID)
Expand Down

0 comments on commit 1ada1c8

Please sign in to comment.