Skip to content

Commit

Permalink
Deprecate legacy overlay storage driver, and add warning
Browse files Browse the repository at this point in the history
The `overlay` storage driver is deprecated in favor of the `overlay2` storage
driver, which has all the benefits of `overlay`, without its limitations (excessive
inode consumption). The legacy `overlay` storage driver will be removed in a future
release. Users of the `overlay` storage driver should migrate to the `overlay2`
storage driver.

The legacy `overlay` storage driver allowed using overlayFS-backed filesystems
on pre 4.x kernels. Now that all supported distributions are able to run `overlay2`
(as they are either on kernel 4.x, or have support for multiple lowerdirs
backported), there is no reason to keep maintaining the `overlay` storage driver.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
  • Loading branch information
thaJeztah committed Oct 11, 2018
1 parent 06fcabb commit 31be4e0
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion daemon/graphdriver/driver.go
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ func isEmptyDir(name string) bool {
func isDeprecated(name string) bool {
switch name {
// NOTE: when deprecating a driver, update daemon.fillDriverInfo() accordingly
case "devicemapper":
case "devicemapper", "overlay":
return true
}
return false
Expand Down
2 changes: 1 addition & 1 deletion daemon/info.go
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ func (daemon *Daemon) fillDriverInfo(v *types.Info) {
drivers += fmt.Sprintf(" (%s) ", os)
}
switch gd {
case "devicemapper":
case "devicemapper", "overlay":
v.Warnings = append(v.Warnings, fmt.Sprintf("WARNING: the %s storage-driver is deprecated, and will be removed in a future release.", gd))
}
}
Expand Down

0 comments on commit 31be4e0

Please sign in to comment.