Add support for custom roundtripper #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: milinddethe15 <milinddethe15@gmail.com>
Signed-off-by: milinddethe15 <milinddethe15@gmail.com>
Signed-off-by: milinddethe15 <milinddethe15@gmail.com>
Signed-off-by: milinddethe15 <milinddethe15@gmail.com>
Signed-off-by: milinddethe15 <milinddethe15@gmail.com>
saswatamcode
approved these changes
Oct 2, 2024
| @@ -20,7 +23,7 @@ type TestCase struct { | |||
| } | |||
|
|
|||
| var validConfig = []byte(`storage_account: "myStorageAccount" | |||
| storage_account_key: "abc123" | |||
| storage_account_key: "bXlTdXBlclNlY3JldEtleTEyMyFAIw==" | |||
There was a problem hiding this comment.
Does this need to be base64 encoded?
There was a problem hiding this comment.
yes, otherwise it would give error.
Signed-off-by: milinddethe15 <milinddethe15@gmail.com>
GiedriusS
approved these changes
Oct 3, 2024
yeya24
reviewed
Oct 31, 2024
| @@ -201,7 +201,7 @@ func (s *overrideSignerType) Retrieve() (credentials.Value, error) { | |||
| } | |||
|
|
|||
| // NewBucketWithConfig returns a new Bucket using the provided s3 config values. | |||
| func NewBucketWithConfig(logger log.Logger, config Config, component string) (*Bucket, error) { | |||
| func NewBucketWithConfig(logger log.Logger, config Config, component string, rt http.RoundTripper) (*Bucket, error) { | |||
There was a problem hiding this comment.
I might be too late to this. But if we already have config.HTTPConfig.Transport, why do we still introduce a new rt parameter?
There was a problem hiding this comment.
We changed this in a follow up PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added a parameter in
NewBucket()to pass custom roundtripperVerification
Created tests in which a
always error returningroundtripper is passed to NewBucket() and tested whether error is caught or not.