Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added roundtripper wrapper as param #150

Merged
merged 5 commits into from
Oct 24, 2024

Conversation

milinddethe15
Copy link
Contributor

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Added a parameter in NewBucket() to pass wrapRoundtripper func(http.RoundTripper) http.RoundTripper

Verification

Created tests in which a always error returning roundtripper wrapper is passed to NewBucket() and tested whether this error is caught or not.

milinddethe15 and others added 4 commits October 21, 2024 22:26
Signed-off-by: milinddethe15 <milinddethe15@gmail.com>
Signed-off-by: milinddethe15 <milinddethe15@gmail.com>
Signed-off-by: milinddethe15 <milinddethe15@gmail.com>
Signed-off-by: Milind Dethe <99114125+milinddethe15@users.noreply.github.com>
Copy link
Member

@GiedriusS GiedriusS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two suggestions but overall great work 🥇

errutil/rt_error.go Outdated Show resolved Hide resolved
errutil/rt_error.go Outdated Show resolved Hide resolved
Copy link
Member

@saswatamcode saswatamcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, if you can address above comments, we can merge! :)

Signed-off-by: milinddethe15 <milinddethe15@gmail.com>
@saswatamcode saswatamcode merged commit 168679c into thanos-io:main Oct 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants