-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure: Add new tenant_id
, client_id
and client_secret
configs
#157
Open
DylanGuedes
wants to merge
5
commits into
thanos-io:main
Choose a base branch
from
DylanGuedes:new-azure-configs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DylanGuedes
force-pushed
the
new-azure-configs
branch
from
November 20, 2024 22:55
2173225
to
534e3b1
Compare
DylanGuedes
force-pushed
the
new-azure-configs
branch
from
November 21, 2024 10:57
6a8655d
to
41f4bec
Compare
DylanGuedes
changed the title
Azure: Add new
Azure: Add new Nov 21, 2024
tenant_id
and client_secret
configstenant_id
, client_id
and client_secret
configs
Signed-off-by: DylanGuedes <djmgguedes@gmail.com>
Signed-off-by: DylanGuedes <djmgguedes@gmail.com>
Signed-off-by: DylanGuedes <djmgguedes@gmail.com>
Signed-off-by: DylanGuedes <djmgguedes@gmail.com>
DylanGuedes
force-pushed
the
new-azure-configs
branch
from
November 29, 2024 11:20
a95a395
to
e1a06ba
Compare
JoaoBraveCoding
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
client_secret
,client_id
, andtenant_id
tenant_id
,client_secret
andclient_id
are set, we use their values to generate an authentication token.Verification
I have created a unitary test locally that interacts with a valid existing Azure blob and I managed to authenticate correctly with the new method.