Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure: Add new tenant_id, client_id and client_secret configs #157

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

DylanGuedes
Copy link

@DylanGuedes DylanGuedes commented Nov 20, 2024

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

  • Adds two new Azure configs: client_secret, client_id, and tenant_id
  • Modifies Azure authentication: if tenant_id, client_secret and client_id are set, we use their values to generate an authentication token.

Verification

I have created a unitary test locally that interacts with a valid existing Azure blob and I managed to authenticate correctly with the new method.

@DylanGuedes DylanGuedes changed the title Azure: Add new tenant_id and client_secret configs Azure: Add new tenant_id, client_id and client_secret configs Nov 21, 2024
Signed-off-by: DylanGuedes <djmgguedes@gmail.com>
Signed-off-by: DylanGuedes <djmgguedes@gmail.com>
Signed-off-by: DylanGuedes <djmgguedes@gmail.com>
Signed-off-by: DylanGuedes <djmgguedes@gmail.com>
Copy link
Collaborator

@JoaoBraveCoding JoaoBraveCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants