Remove command-line flags page from query UI #1216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thanks for this! I think it makes sense but I would vote for not changing the Can we just remove command line flags? (: |
|
Ok i will leave the status page as it is in master |
|
@bwplotka status dropdown is back |
bwplotka
approved these changes
Jun 4, 2019
FUSAKLA
pushed a commit
to FUSAKLA/thanos
that referenced
this pull request
Jun 8, 2019
* Remove command-line flags page from query UI * Dummy commit for relaunch ci job * Put back status dropdown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #248
Changes
I removed the command line flags panel from the query UI. Since there is now only one section to the Status drop-down, I removed it to only keep the Runtime & Build Information panel in the global menu