*: Initialize gRPC server metrics #1478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brancz
reviewed
Aug 29, 2019
kakkoyun
force-pushed
the
initialize_grpc_metrics
branch
2 times, most recently
from
27ab81b
to
1636ff3
Compare
brancz
approved these changes
Sep 2, 2019
|
It's failed because of a dependency issue: >> fetching github.com/minio/minio@RELEASE.2018-10-06T00-15-16Z revision/version
# cd .; git clone https://git.apache.org/thrift.git /tmp/thanos-go/src/git.apache.org/thrift.git
Cloning into '/tmp/thanos-go/src/git.apache.org/thrift.git'...
fatal: unable to access 'https://git.apache.org/thrift.git/': Failed to connect to git.apache.org port 443: Connection timed out
package github.com/minio/minio
imports git.apache.org/thrift.git/lib/go/thrift: exit status 128
Makefile:209: recipe for target 'test-deps' failed
make[2]: *** [test-deps] Error 1
make[2]: Leaving directory '/go/src/github.com/thanos-io/thanos'
Makefile:193: recipe for target 'test-only-gcs' failed
make[1]: *** [test-only-gcs] Error 2
make[1]: Leaving directory '/go/src/github.com/thanos-io/thanos'
Makefile:202: recipe for target 'test-local' failed
make: *** [test-local] Error 2
Exited with code 2 |
|
There's already an issue (#1483) opened for the failure. |
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
kakkoyun
force-pushed
the
initialize_grpc_metrics
branch
from
1636ff3
to
1bf2966
Compare
brancz
approved these changes
Sep 3, 2019
wbh1
pushed a commit
to wbh1/thanos
that referenced
this pull request
Sep 17, 2019
* Initialize grpc server metrics Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Ad change log Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Refactor. Separate server initialization from server options Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR initializes gRPC server metrics as soon as server starts, to provide more reliable data for instrumentation.
Changes
Verification
make test | build | lintand local test