cmd/thanos/flags: remove unhelpful flags helper #1652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit cleans up a TODO in the flags.go file and eliminates the regCommonServerFlags func, which added almost no additional utility beyond calling regGRPCFlags and regHTTPAddrFlag. Signed-off-by: Lucas Servén Marín <lserven@gmail.com>
GiedriusS
pushed a commit
that referenced
this pull request
Oct 28, 2019
This commit cleans up a TODO in the flags.go file and eliminates the regCommonServerFlags func, which added almost no additional utility beyond calling regGRPCFlags and regHTTPAddrFlag. Signed-off-by: Lucas Servén Marín <lserven@gmail.com> Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit cleans up a TODO in the flags.go file and eliminates the
regCommonServerFlags func, which added almost no additional utility
beyond calling regGRPCFlags and regHTTPAddrFlag.
Signed-off-by: Lucas Servén Marín lserven@gmail.com
low-priority cleanup.
cc @povilasv @bwplotka