Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mixin: Fix wrong querier metric name #2005

Merged

Conversation

kakkoyun
Copy link
Member

This PR fixes wrong querier metric name.

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

  • Rename thanos_query_store_apis_dns_failures_total to thanos_querier_store_apis_dns_failures_total

Verification

  1. make examples-lint
  2. Manuel test using promdash.

@kakkoyun kakkoyun force-pushed the fix_thanos_querier_metrics branch from c78c8f5 to a0c9757 Compare January 15, 2020 12:27
@metalmatze
Copy link
Contributor

We might just want to open this against release-0.10 as a bugfix too. Then we can merge it into master and have it in a next patch release, if one happens :)

Copy link
Member

@squat squat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch here

@brancz
Copy link
Member

brancz commented Jan 15, 2020

We might just want to open this against release-0.10 as a bugfix too. Then we can merge it into master and have it in a next patch release, if one happens :)

Agreed. Let's point this against the release branch and then merge the release branch back into master.

@kakkoyun kakkoyun changed the base branch from master to release-0.10 January 15, 2020 13:14
@kakkoyun kakkoyun force-pushed the fix_thanos_querier_metrics branch from a0c9757 to d5a3fd1 Compare January 15, 2020 13:18
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
@GiedriusS
Copy link
Member

Thanks, will release 0.10.1 with the other fix.

@GiedriusS GiedriusS merged commit 7d16852 into thanos-io:release-0.10 Jan 21, 2020
GiedriusS pushed a commit to GiedriusS/thanos that referenced this pull request Jan 21, 2020
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com>
@kakkoyun kakkoyun deleted the fix_thanos_querier_metrics branch January 21, 2020 16:19
GiedriusS added a commit that referenced this pull request Jan 21, 2020
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com>

Co-authored-by: Kemal Akkoyun <kakkoyun@users.noreply.github.com>
bwplotka added a commit that referenced this pull request Jan 23, 2020
bwplotka added a commit that referenced this pull request Jan 24, 2020
* Fix invalid start/end params in series api (#2015)

* fix invalid start/end params in series api

Signed-off-by: yeya24 <yb532204897@gmail.com>

* add testcase for serieslabels time range

Signed-off-by: yeya24 <yb532204897@gmail.com>

* Revert "Fix revert metric name regression (#2005)"

This reverts commit 7d16852.

* Cut release 0.10.1

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>

Co-authored-by: Ben Ye <yb532204897@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants