-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query Frontend: Set CORS header #3414
Conversation
6029089
to
d98777c
Compare
Does this also work when you use POST? Because we have: var corsHeaders = map[string]string{
"Access-Control-Allow-Headers": "Accept, Accept-Encoding, Authorization, Content-Type, Origin",
"Access-Control-Allow-Methods": "GET, OPTIONS",
"Access-Control-Allow-Origin": "*",
"Access-Control-Expose-Headers": "Date",
} |
@GiedriusS that's an interesting question. I wonder how it works right now with Querier. I am looking into this. |
Even now (thanos 0.16), POST is not allowed from what I see
🤔 |
3a4fbba
to
3e4ac53
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion and LGTM (:
Set CORS to the query frontend component in order to be able to freely access it from Grafana's living elsewhere. This is similar to what already happens for the Query component. Signed-off-by: Markos Chandras <markos@chandras.me>
3e4ac53
to
959c300
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Set CORS to the query frontend component in order to be able to freely access it from Grafana's living elsewhere. This is similar to what already happens for the Query component. Signed-off-by: Markos Chandras <markos@chandras.me> Signed-off-by: Oghenebrume50 <raphlbrume@gmail.com>
Set CORS to the query frontend component in order to be able
to freely access it from Grafana's living elsewhere.
Signed-off-by: Markos Chandras markos@chandras.me
Changes
Set
Access-Control-Allow-Origin
Header to Query FrontendVerification
make test-e2e-local