Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query-frontend: make POST-request to downstream url for labels and series api endpoints #3444

Merged

Conversation

2nick
Copy link
Contributor

@2nick 2nick commented Nov 13, 2020

Also probably fixes series endpoint proxying as ThanosSeriesResponse.Data used LabelSet which has no UnmarshalJSON (simply changing to ZLabelSet).

@2nick 2nick force-pushed the query-frontend-series-labels-api-post branch from 7159dc3 to dd6dee7 Compare November 13, 2020 21:00
…ries api endpoints

Signed-off-by: Alexander Tunik <2braven@gmail.com>
@2nick 2nick force-pushed the query-frontend-series-labels-api-post branch from dd6dee7 to 49ea2ce Compare November 14, 2020 10:15
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

LGTM

@bwplotka bwplotka merged commit f6f622b into thanos-io:master Nov 16, 2020
yeya24 pushed a commit to yeya24/thanos that referenced this pull request Nov 20, 2020
…ries api endpoints (thanos-io#3444)

Signed-off-by: Alexander Tunik <2braven@gmail.com>
bwplotka pushed a commit that referenced this pull request Nov 23, 2020
* query-frontend: make POST-request to downstream url for labels and series api endpoints (#3444)

Signed-off-by: Alexander Tunik <2braven@gmail.com>

* remove default response cache config

Signed-off-by: Ben Ye <yb532204897@gmail.com>

* ensure order when merging multiple responses

Signed-off-by: Ben Ye <yb532204897@gmail.com>

Co-authored-by: Alexander Tunik <2braven@gmail.com>
Oghenebrume50 pushed a commit to Oghenebrume50/thanos that referenced this pull request Dec 7, 2020
…ries api endpoints (thanos-io#3444)

Signed-off-by: Alexander Tunik <2braven@gmail.com>
Signed-off-by: Oghenebrume50 <raphlbrume@gmail.com>
metalmatze pushed a commit to metalmatze/thanos that referenced this pull request Dec 9, 2020
* query-frontend: make POST-request to downstream url for labels and series api endpoints (thanos-io#3444)

Signed-off-by: Alexander Tunik <2braven@gmail.com>

* remove default response cache config

Signed-off-by: Ben Ye <yb532204897@gmail.com>

* ensure order when merging multiple responses

Signed-off-by: Ben Ye <yb532204897@gmail.com>

Co-authored-by: Alexander Tunik <2braven@gmail.com>
bwplotka added a commit that referenced this pull request Dec 9, 2020
* Fix query frontend regression on release v0.17.0 (#3480)

* query-frontend: make POST-request to downstream url for labels and series api endpoints (#3444)

Signed-off-by: Alexander Tunik <2braven@gmail.com>

* remove default response cache config

Signed-off-by: Ben Ye <yb532204897@gmail.com>

* ensure order when merging multiple responses

Signed-off-by: Ben Ye <yb532204897@gmail.com>

Co-authored-by: Alexander Tunik <2braven@gmail.com>

* *: Set debug.SetPanicOnFault(true) so we can recover seg faults. (#3498)

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>

* Prepare v0.17.1 release (#3505)

Signed-off-by: Matthias Loibl <mail@matthiasloibl.com>

* fix index out of bound bug when comparing ZLabelSets (#3520)

* fix index out of bound bug when comparing ZLabelSets

Signed-off-by: Ben Ye <yb532204897@gmail.com>

* fix param parsing error message

Signed-off-by: Ben Ye <yb532204897@gmail.com>

* address comment feedbacks

Signed-off-by: Ben Ye <yb532204897@gmail.com>

* compact: do not cleanup blocks on boot (#3532)

Do not cleanup blocks on boot because in some very bad cases there could
be thousands of blocks ready-to-be deleted and doing that makes Thanos
Compact exceed `initialDelaySeconds` on k8s.

Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com>

* Prepare v0.17.2 (#3543)

Signed-off-by: Matthias Loibl <mail@matthiasloibl.com>

* Properly rebase CHANGELOG.md after merging release-0.17

Signed-off-by: Matthias Loibl <mail@matthiasloibl.com>

Co-authored-by: Ben Ye <yb532204897@gmail.com>
Co-authored-by: Alexander Tunik <2braven@gmail.com>
Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
Co-authored-by: Giedrius Statkevičius <giedriuswork@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants