Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge release-0.19 to main. #4008

Merged
merged 17 commits into from
Apr 9, 2021
Merged

Merge release-0.19 to main. #4008

merged 17 commits into from
Apr 9, 2021

Commits on Mar 2, 2021

  1. Cut v0.19.0-rc.0 (#3860)

    Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
    bwplotka authored Mar 2, 2021
    Configuration menu
    Copy the full SHA
    139ae3f View commit details
    Browse the repository at this point in the history
  2. Fixed missed changelog comments. (#3865)

    Missed from: #3860
    
    Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
    bwplotka authored Mar 2, 2021
    Configuration menu
    Copy the full SHA
    93f2605 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2021

  1. rename Metadata API to MetricMetadata API (#3877)

    Signed-off-by: yeya24 <yb532204897@gmail.com>
    yeya24 authored Mar 5, 2021
    Configuration menu
    Copy the full SHA
    af4ee3a View commit details
    Browse the repository at this point in the history
  2. Fix parseStep bug introduced in PR #3740 (#3887) (#3889)

    * Fix bug introduced in PR #3740
    
    Signed-off-by: Hitanshu Mehta <hitanshu99amehta@gmail.com>
    
    * Minor change in test
    
    Signed-off-by: Hitanshu Mehta <hitanshu99amehta@gmail.com>
    
    Co-authored-by: Hitanshu Mehta <44025541+hitanshu-mehta@users.noreply.github.com>
    bwplotka and hitanshu-mehta authored Mar 5, 2021
    Configuration menu
    Copy the full SHA
    26077e0 View commit details
    Browse the repository at this point in the history
  3. Tools: rewrite delete can delete series only if it matches all matche…

    …rs (#3886) (#3890)
    
    * rewrite delete should delete a series only if it matches all matchers in a deletion request
    
    Signed-off-by: yeya24 <yb532204897@gmail.com>
    
    * add test case
    
    Signed-off-by: yeya24 <yb532204897@gmail.com>
    
    Co-authored-by: Ben Ye <yb532204897@gmail.com>
    bwplotka and yeya24 authored Mar 5, 2021
    Configuration menu
    Copy the full SHA
    92b4452 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2021

  1. cmd/thanos/receive.go: Receive client infers TLS (#3899)

    Currently, the thanos Receiver infers whether it should use TLS for
    the gRPC clients that forwards time series to other receivers based on
    whether the remote-write HTTP server uses TLS. This is not correct, as
    the HTTP server may use TLS without the gRPC server using TLS. This
    commit fixes the inference.
    
    Longer-term, this will be taken care of by the receive/router split.
    
    Signed-off-by: Lucas Servén Marín <lserven@gmail.com>
    squat authored Mar 9, 2021
    Configuration menu
    Copy the full SHA
    b7da5a1 View commit details
    Browse the repository at this point in the history
  2. Cut v0.19.0-rc.1 (#3900)

    Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
    bwplotka authored Mar 9, 2021
    Configuration menu
    Copy the full SHA
    05280c9 View commit details
    Browse the repository at this point in the history
  3. tools: Fix partial and empty matchers in rewrite (#3891)

    * Fix partial and empty matchers match
    
    Signed-off-by: yeya24 <yb532204897@gmail.com>
    
    * add testcase for non-equal matchers
    
    Signed-off-by: yeya24 <yb532204897@gmail.com>
    yeya24 authored Mar 9, 2021
    Configuration menu
    Copy the full SHA
    38d78b5 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2021

  1. v0.19.0 patch: Added receive benchmark; Fixed Receiver excessive mem …

    …usage introduced in 0.17 (#3943)
    
    * Added receive benchmark, baseline.
    
    ```
    goos: linux
    goarch: amd64
    pkg: github.com/thanos-io/thanos/pkg/receive
    BenchmarkHandlerReceiveHTTP
    BenchmarkHandlerReceiveHTTP/typical_labels_under_1KB,_500_of_them.
    BenchmarkHandlerReceiveHTTP/typical_labels_under_1KB,_500_of_them./OK
    BenchmarkHandlerReceiveHTTP/typical_labels_under_1KB,_500_of_them./OK-12      	   22260	   1550152 ns/op	 1380340 B/op	    6093 allocs/op
    BenchmarkHandlerReceiveHTTP/typical_labels_under_1KB,_500_of_them./conflict_errors
    BenchmarkHandlerReceiveHTTP/typical_labels_under_1KB,_500_of_them./conflict_errors-12         	    6619	   6430408 ns/op	 4522487 B/op	   26118 allocs/op
    BenchmarkHandlerReceiveHTTP/typical_labels_under_1KB,_5000_of_them.
    BenchmarkHandlerReceiveHTTP/typical_labels_under_1KB,_5000_of_them./OK
    BenchmarkHandlerReceiveHTTP/typical_labels_under_1KB,_5000_of_them./OK-12                     	    2695	  17208794 ns/op	15072963 B/op	   60441 allocs/op
    BenchmarkHandlerReceiveHTTP/typical_labels_under_1KB,_5000_of_them./conflict_errors
    BenchmarkHandlerReceiveHTTP/typical_labels_under_1KB,_5000_of_them./conflict_errors-12        	     474	  72533286 ns/op	46396932 B/op	  260141 allocs/op
    BenchmarkHandlerReceiveHTTP/extremely_large_label_value_10MB,_10_of_them
    BenchmarkHandlerReceiveHTTP/extremely_large_label_value_10MB,_10_of_them/OK
    BenchmarkHandlerReceiveHTTP/extremely_large_label_value_10MB,_10_of_them/OK-12                	     270	 137050518 ns/op	226595379 B/op	     132 allocs/op
    BenchmarkHandlerReceiveHTTP/extremely_large_label_value_10MB,_10_of_them/conflict_errors
    BenchmarkHandlerReceiveHTTP/extremely_large_label_value_10MB,_10_of_them/conflict_errors-12   	      21	1616025443 ns/op	698724321 B/op	     408 allocs/op
    PASS
    
    Process finished with exit code 0
    ```
    
    
    Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
    
    * Copy labels.
    
    ```
    GOROOT=/home/bwplotka/.gvm/gos/go1.15 #gosetup
    GOPATH=/home/bwplotka/Repos/thanosgopath #gosetup
    /home/bwplotka/.gvm/gos/go1.15/bin/go test -c -o /tmp/___BenchmarkHandlerReceiveHTTP_in_github_com_thanos_io_thanos_pkg_receive github.com/thanos-io/thanos/pkg/receive #gosetup
    /tmp/___BenchmarkHandlerReceiveHTTP_in_github_com_thanos_io_thanos_pkg_receive -test.v -test.bench ^\QBenchmarkHandlerReceiveHTTP\E$ -test.run ^$ -test.benchmem -test.benchtime=30s
    goos: linux
    goarch: amd64
    pkg: github.com/thanos-io/thanos/pkg/receive
    BenchmarkHandlerReceiveHTTP
    BenchmarkHandlerReceiveHTTP/typical_labels_under_1KB,_500_of_them
    BenchmarkHandlerReceiveHTTP/typical_labels_under_1KB,_500_of_them/OK
    BenchmarkHandlerReceiveHTTP/typical_labels_under_1KB,_500_of_them/OK-12      	   25887	   1537262 ns/op	 1380023 B/op	    6092 allocs/op
    BenchmarkHandlerReceiveHTTP/typical_labels_under_1KB,_500_of_them/conflict_errors
    BenchmarkHandlerReceiveHTTP/typical_labels_under_1KB,_500_of_them/conflict_errors-12         	    4237	   7547968 ns/op	 4522583 B/op	   26118 allocs/op
    BenchmarkHandlerReceiveHTTP/typical_labels_under_1KB,_5000_of_them
    BenchmarkHandlerReceiveHTTP/typical_labels_under_1KB,_5000_of_them/OK
    BenchmarkHandlerReceiveHTTP/typical_labels_under_1KB,_5000_of_them/OK-12                     	    2205	  16513380 ns/op	15071092 B/op	   60420 allocs/op
    BenchmarkHandlerReceiveHTTP/typical_labels_under_1KB,_5000_of_them/conflict_errors
    BenchmarkHandlerReceiveHTTP/typical_labels_under_1KB,_5000_of_them/conflict_errors-12        	     525	  67278233 ns/op	46396645 B/op	  260141 allocs/op
    BenchmarkHandlerReceiveHTTP/extremely_large_label_value_10MB,_10_of_them
    BenchmarkHandlerReceiveHTTP/extremely_large_label_value_10MB,_10_of_them/OK
    BenchmarkHandlerReceiveHTTP/extremely_large_label_value_10MB,_10_of_them/OK-12               	     285	 148049189 ns/op	226596168 B/op	     132 allocs/op
    BenchmarkHandlerReceiveHTTP/extremely_large_label_value_10MB,_10_of_them/conflict_errors
    BenchmarkHandlerReceiveHTTP/extremely_large_label_value_10MB,_10_of_them/conflict_errors-12  	      20	1731361499 ns/op	698722550 B/op	     401 allocs/op
    PASS
    
    Process finished with exit code 0
    
    ```
    
    Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
    
    * Addded bench.,
    
    Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
    
    * Fix.
    
    Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
    
    * Improved API.
    
    Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
    
    * Changelog.
    
    Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
    
    * Addressed Lucas comments.
    
    Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
    bwplotka authored Mar 20, 2021
    Configuration menu
    Copy the full SHA
    b446fae View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2021

  1. compact: clean up directories thoroughly (#3869)

    * compact: clean up directories properly
    
    I couldn't stop thinking about this code for some reason and I have
    figured that I had missed one case in #3031. We need to also clean up
    the directories in compaction groups. A compaction could fail leaving
    some new directory with a random ULID on the disk. Before attempting to
    do another compaction loop, we need to remove it as well because the
    compaction process always produces a new, unique directory.
    
    Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com>
    
    * Remove all non expected dirs.
    
    Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
    
    * Addressed comment.
    
    Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
    
    Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
    GiedriusS and bwplotka authored Mar 24, 2021
    Configuration menu
    Copy the full SHA
    1dce996 View commit details
    Browse the repository at this point in the history
  2. Added benchmark, Moved minio-deps to fork without race fix we don't n…

    …eed. (#3968)
    
    Fixes: #3917
    
    Long term fix: #3967
    
    Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
    bwplotka authored Mar 24, 2021
    Configuration menu
    Copy the full SHA
    7002609 View commit details
    Browse the repository at this point in the history
  3. Cut v0.19.0-rc.2 (#3969)

    Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
    bwplotka authored Mar 24, 2021
    Configuration menu
    Copy the full SHA
    5620c09 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2021

  1. pkg/rules: fix deduplication of equal alerts with different labels (#…

    …3960) (#3999)
    
    Currently, if an alerting rule having the same name with different
    severity labels is being returned from different replicas then they
    are being treated as separate alerts.
    
    Given the following alerts a1,a2 with severities s1,s2 returned from
    replicas r1,2:
    
    a1[s1,r1]
    a1[s2,r1]
    a1[s1,r2]
    a1[s2,r2]
    
    Then, currently, the algorithm deduplicates to:
    
    a1[s1]
    a1[s2]
    a1[s1]
    a1[s2]
    
    Instead of the intendet result:
    
    a1[s1]
    a1[s2]
    
    This fixes it by removing replica labels before sorting labels for
    deduplication.
    
    Signed-off-by: Sergiusz Urbaniak <sergiusz.urbaniak@gmail.com>
    # Conflicts:
    #	CHANGELOG.md
    
    Co-authored-by: Sergiusz Urbaniak <sergiusz.urbaniak@gmail.com>
    bwplotka and s-urbaniak authored Mar 31, 2021
    Configuration menu
    Copy the full SHA
    faf1d04 View commit details
    Browse the repository at this point in the history
  2. Cut v0.19.0 (#3998)

    Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
    bwplotka authored Mar 31, 2021
    Configuration menu
    Copy the full SHA
    18c0dbe View commit details
    Browse the repository at this point in the history
  3. Fixed VERSION file.

    Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
    bwplotka committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    ba6c5c4 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2021

  1. Merge branch 'release-0.19' into merge-v0.19

    # Conflicts:
    #	CHANGELOG.md
    #	VERSION
    #	cmd/thanos/receive.go
    #	pkg/receive/handler_test.go
    bwplotka committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    99899b2 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'main' into merge-v0.19

    # Conflicts:
    #	pkg/metadata/prometheus_test.go
    #	test/e2e/metadata_api_test.go
    bwplotka committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    801c7c1 View commit details
    Browse the repository at this point in the history