Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cm-promql to v0.15.0 #4054

Merged
merged 3 commits into from
Apr 15, 2021
Merged

Conversation

Nexucis
Copy link
Contributor

@Nexucis Nexucis commented Apr 13, 2021

  • upgrade codemirror-promql to v0.15.0
  • inject the metricNames in the PromQLExtension
  • update the import paths accordingly to the changes provided by this new release.
  • I also took the opportunity to move the @types packages from the dependencies list to the dev-dependencies. I hope you don't mind that I did it.
    the @types/ packages are only used for the development, and not used to run the webapp. So these should move to the dev-dependencies part.

This PR synchronizes the changes performed on Prometheus side through the PRs prometheus/prometheus#8706 and prometheus/prometheus#8719

Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this work. We really appreciate this work 🤗

At one point... would like to help us maintaining Thanos on UI side?

@bwplotka bwplotka merged commit eb05f79 into thanos-io:main Apr 15, 2021
@Nexucis Nexucis deleted the feature/bump-cm-promql branch April 15, 2021 16:36
@Nexucis
Copy link
Contributor Author

Nexucis commented Apr 15, 2021

Oh cool thanks @bwplotka.

At one point... would like to help us maintaining Thanos on UI side?

Maybe it could be nice at some point, but maybe before saying a definitive yes, it would be nice to know what is the expectations and what does it mean to do that :D.

@bwplotka
Copy link
Member

You can always chat with us about those things on our CNCF Slack with @onprem (@Prem Saraswat on Slack, maintainer currently the most familiar of frontend part) and me (@bwplotka on Slack) 🤗

Also: https://thanos.io/tip/thanos/maintainers.md/#how-to-be-maintainer

@bwplotka
Copy link
Member

You can always chat with us about those things on our CNCF Slack with @onprem (@Prem Saraswat on Slack, maintainer currently the most familiar of frontend part) and me (@bwplotka on Slack) 🤗

And anyone else interested to help in any part of Thanos project!

someshkoli pushed a commit to someshkoli/thanos that referenced this pull request Apr 21, 2021
* move @types deps to dev-deps

Signed-off-by: Augustin Husson <husson.augustin@gmail.com>

* bump cm-promql to v0.15.0

Signed-off-by: Augustin Husson <husson.augustin@gmail.com>

* use the metricsNames in PromQLExtension & update the import path

Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
Signed-off-by: someshkoli <kolisomesh27@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants