Add env substitution to pathorcontent
#4327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
saswatamcode
force-pushed
the
use-tools-pathorcontent
branch
from
b47043f
to
9dce7fc
Compare
bwplotka
previously approved these changes
Jun 11, 2021
There was a problem hiding this comment.
This LGTM, but let's wait for others 👀 too.
@thanos-io/thanos-maintainers this moves pathOrContent to separate reusable go module BUT it also adds environment variable substitution which makes our flags with config accept environment variables within YAML config using $()
|
|
||
| return extflag.RegisterPathOrContent(cmd, fmt.Sprintf("objstore%s.config", suffix), help, required) | ||
| opts := []extflag.Option{extflag.WithEnvSubstitution()} | ||
| if required { |
kakkoyun
previously approved these changes
Jun 11, 2021
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
bwplotka
approved these changes
Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds environment variable substitution to
pathorcontentflag by replacingpkg/extflag/pathorcontent.gowithgit.luolix.top/efficientgo/tools/extkingpin. This was added as a new module here. Addresses #4293.Verification
Tested locally.