Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

querier: per-endpoint configuration #4785

Closed
wants to merge 29 commits into from
Closed

querier: per-endpoint configuration #4785

wants to merge 29 commits into from

Conversation

bwplotka
Copy link
Member

Suggested changes to #4389 (could not somehow create PR for a PR).

cc @Namanl2001

This needs more work, tests, lint etc, but shows a direction hopefully

Namanl2001 and others added 29 commits October 14, 2021 22:03
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
@stale
Copy link

stale bot commented Jan 3, 2022

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Jan 3, 2022
@Namanl2001
Copy link
Contributor

Hi @matej-g @bwplotka @GiedriusS - are these changes still relevant? How can we take this PR further?

PS: #2600 (comment)

@stale stale bot removed the stale label Jan 10, 2022
@matej-g
Copy link
Collaborator

matej-g commented Jan 11, 2022

Hi @matej-g @bwplotka @GiedriusS - are these changes still relevant? How can we take this PR further?

Hey @Namanl2001, I'm pretty sure we still need this! I wanted to take a look, but alas didn't have a time. You mentioned you struggle with implementing certain function? What is the issue specifically? Are there other things on which are you blocked beside that function?

@yeya24
Copy link
Contributor

yeya24 commented Jan 15, 2022

@Namanl2001 Can you help fix the conflicts? Would be really nice to have this next release.

@Namanl2001
Copy link
Contributor

@Namanl2001 Can you help fix the conflicts? Would be really nice to have this next release.

actually, I'm away from this for a long time now and there are many merge conflicts that need to be resolved, will try to proceed once I get time :)

You mentioned you struggle with implementing certain function? What is the issue specifically?

yes @matej-g - earlier I tried to implement that function but was not able to do so, due to lack of understanding

@matej-g
Copy link
Collaborator

matej-g commented Feb 9, 2022

Hey @Namanl2001, I'll have time next week to look into this, would you want to pair up on this feature? Alternatively, if you're busy, I'm happy to try and take over.

@Namanl2001
Copy link
Contributor

That would be great @matej-g , let's pair up and get this work done.

@stale
Copy link

stale bot commented Apr 16, 2022

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Apr 16, 2022
@matej-g
Copy link
Collaborator

matej-g commented Apr 19, 2022

This is still sorely needed 😢

@stale stale bot removed the stale label Apr 19, 2022
@Namanl2001
Copy link
Contributor

hey @matej-g! I don't have the bandwidth to work on this. so feel free to take this up. Thanks 😄

@bwplotka
Copy link
Member Author

Yes. Help wanted, I personally won't be able to touch it before mid-June

@bwplotka
Copy link
Member Author

bwplotka commented May 9, 2022

Let's close it, for now, @saswatamcode is creating issue summarizing this - we will propose this as mentorship topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants