Adds GitHub flow to automate busybox container SHAs #4965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiardvanrij
force-pushed
the
feature/busybox-updater
branch
from
dc3f547 to
39767fa
Compare
saswatamcode
previously approved these changes
Dec 17, 2021
matej-g
previously approved these changes
Dec 17, 2021
wiardvanrij
dismissed stale reviews from matej-g and saswatamcode
via
6fc72e3
yeya24
reviewed
Dec 18, 2021
yeya24
previously approved these changes
Dec 18, 2021
|
I currently don't have a workstation anymore, figured to manually edit those things via GitHub online. Seems like it won't sign my commits then.. :( |
wiardvanrij
force-pushed
the
feature/busybox-updater
branch
from
f88c8d1 to
e4e34ce
Compare
wiardvanrij
force-pushed
the
feature/busybox-updater
branch
from
42ebcbc to
e4e34ce
Compare
wiardvanrij
force-pushed
the
feature/busybox-updater
branch
from
e4e34ce to
87424ee
Compare
Signed-off-by: Rij, W. van (Wiard) <wiard@outlook.com> Signed-off-by: Wiard van Rij <wiard@pop-os.localdomain> Signed-off-by: Wiard van Rij <wiard@outlook.com>
Signed-off-by: Rij, W. van (Wiard) <wiard@outlook.com> Signed-off-by: Wiard van Rij <wiard@pop-os.localdomain> Signed-off-by: Wiard van Rij <wiard@outlook.com>
Signed-off-by: Rij, W. van (Wiard) <wiard@outlook.com> Signed-off-by: Wiard van Rij <wiard@pop-os.localdomain> Signed-off-by: Wiard van Rij <wiard@outlook.com>
Signed-off-by: Rij, W. van (Wiard) <wiard@outlook.com> Signed-off-by: Wiard van Rij <wiard@pop-os.localdomain> Signed-off-by: Wiard van Rij <wiard@outlook.com>
Signed-off-by: Rij, W. van (Wiard) <wiard@outlook.com> Signed-off-by: Wiard van Rij <wiard@pop-os.localdomain> Signed-off-by: Wiard van Rij <wiard@outlook.com>
Signed-off-by: Rij, W. van (Wiard) <wiard@outlook.com> Signed-off-by: Wiard van Rij <wiard@pop-os.localdomain> Signed-off-by: Wiard van Rij <wiard@outlook.com>
Adds newline Signed-off-by: Wiard van Rij <wiard@pop-os.localdomain> Signed-off-by: Wiard van Rij <wiard@outlook.com>
Adds newline Signed-off-by: Wiard van Rij <wiard@pop-os.localdomain> Signed-off-by: Wiard van Rij <wiard@outlook.com>
wiardvanrij
force-pushed
the
feature/busybox-updater
branch
from
87424ee to
2748916
Compare
Signed-off-by: Wiard van Rij <wiard@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rij, W. van (Wiard) wiard@outlook.com
Relates to #4949
Changes
The .github workflow does a cronjob task. It checks Quay for the latest Prometheus/busybox and fetches the SHA's for all platforms. These values are placed as bash variables in
.busybox-versions. That file is included in the Makefile so the vars can be used as build arguments.The cronjob will make a PR against
main, if there is a change.Consider changing the cronjob to do it every 2-3 days, and allow manual updates if needed (?).
The reason we pin the version is that we want to know which version we are using AND that builds are consistent. Not just for the main branch but as well for local development, etc.
Verification
I have tested this in my own fork. Which did work. I assume (ye ye) it should work here as well out of the box. I can't test if we have the proper rights, but it should be fine as I did not use any special things here.