[Website] fixed overflow company images and hero section logo #5015
Conversation
Signed-off-by: Nikhil Sharma <nikhilsharmamusic2000@gmail.com>
Signed-off-by: Nikhil Sharma <nikhilsharmamusic2000@gmail.com>
website/static/main.css
Outdated
| flex-grow: 1; | ||
| max-width: 100%; | ||
| } | ||
| } |
There was a problem hiding this comment.
Looks pretty good @NikhilSharma03
Can you share "after" screenshots too?
website/static/main.css
Outdated
| .img-adopter img { | ||
| max-width: 100%; | ||
| max-height: 100%; | ||
| .img-adopter a{ |
There was a problem hiding this comment.
Nit:
| .img-adopter a{ | |
| .img-adopter a { |
Signed-off-by: Nikhil Sharma <nikhilsharmamusic2000@gmail.com>
After ChangesFixed Overflow company images in Used By section
Extremely Small logo image in Hero section (from viewport 576px - 750px)
|
|
Looks really clean! Do you think it's possible to make them all equal in size? Now it sort of looks like "premium" users due to the size difference :) |
|
@wiardvanrij I see 🤔 . Actually, the containers are of the same sizes. It is just that the image logo styles(and dimentions) are different. |
|
Tried using
What do you think? 😕 |
I think we already had this problem before, so I wouldn't make it a blocker for this fix. Nevertheless, I think that the fundamental issue there is that our containers have a specific width:height ratio so logos that are closer to that ratio will appear larger. On top of that, some logos have more padding in their images than others. I don't think there's anything we can do trivially to solve these issues, other than cropping logos to be the same size. An additional option would be to fix one dimension, e.g. height, and allow the other dimension to grow. However, this would result in a page that is not a fixed grid and would actually give non-square logos an advantage. Logos that are very wide would have tons of area while square or narrow logos would have much smaller areas. |
|
Ah, @NikhilSharma03 I think what @wiardvanrij is referring to is actually the last row. Because this row has fewer logos, the containers are all larger. Can we make it so that containers are always the same width? |
|
@squat Actually All of the containers are of the same width. In the Screenshot (Last Row), I just cropped out the Preview: |
|
Right, awesome job 😎 |
|
Ah ok, I see, the were two different images |
You can actually open the Netlify preview to see the difference 😎 |
Changes
This PR Fixes two issues in the website
Overflow company images in
Used BysectionExtremely Small logo image in
Herosection (from viewport 576px - 750px)Verification