Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: cut 0.30.1 #6017

Merged
merged 2 commits into from
Jan 4, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,12 @@ We use *breaking :warning:* to mark changes that are not backward compatible (re

## Unreleased

## [v0.30.1](https://github.com/thanos-io/thanos/tree/release-0.30) - 4.01.2023

### Fixed

- [#6009](https://github.com/thanos-io/thanos/pull/6009) Query Frontend/Store: fix duplicate metrics registration in Redis client

## [v0.30.0](https://github.com/thanos-io/thanos/tree/release-0.30) - 2.01.2023

NOTE: Querier's `query.promql-engine` flag enabling new PromQL engine is now unhidden. We encourage users to use new experimental PromQL engine for efficiency reasons.
Expand Down
2 changes: 1 addition & 1 deletion VERSION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.30.0
0.30.1
6 changes: 5 additions & 1 deletion pkg/cacheutil/cacheutil_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,11 @@ import (
)

func TestMain(m *testing.M) {
goleak.VerifyTestMain(m)
goleak.VerifyTestMain(
m,
// https://github.com/rueian/rueidis/blob/v0.0.90/pipe.go#L204.
goleak.IgnoreTopFunction("github.com/rueian/rueidis.(*pipe).backgroundPing"),
)
}

func TestDoWithBatch(t *testing.T) {
Expand Down
4 changes: 4 additions & 0 deletions pkg/cacheutil/redis_client.go
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,10 @@ func NewRedisClientWithConfig(logger log.Logger, name string, config RedisClient
return nil, err
}

if reg != nil {
reg = prometheus.WrapRegistererWith(prometheus.Labels{"name": name}, reg)
}

var tlsConfig *tls.Config
if config.TLSEnabled {
userTLSConfig := config.TLSConfig
Expand Down
16 changes: 16 additions & 0 deletions pkg/cacheutil/redis_client_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -212,3 +212,19 @@ func TestValidateRedisConfig(t *testing.T) {
}

}

func TestMultipleRedisClient(t *testing.T) {
s, err := miniredis.Run()
if err != nil {
testutil.Ok(t, err)
}
defer s.Close()
cfg := DefaultRedisClientConfig
cfg.Addr = s.Addr()
logger := log.NewLogfmtLogger(os.Stderr)
reg := prometheus.NewRegistry()
_, err = NewRedisClientWithConfig(logger, "test1", cfg, reg)
testutil.Ok(t, err)
_, err = NewRedisClientWithConfig(logger, "test2", cfg, reg)
testutil.Ok(t, err)
}