Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support other type of matchers in replicate #6035

Merged
merged 3 commits into from
Jan 13, 2023
Merged

support other type of matchers in replicate #6035

merged 3 commits into from
Jan 13, 2023

Conversation

kama910
Copy link
Contributor

@kama910 kama910 commented Jan 11, 2023 •
edited
Loading

Signed-off-by: Kama Huang kamatogo13@gmail.com

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Fixes #5038

Verification

@kama910
support other type of matchers in replicate
e6cfec7 
Signed-off-by: Kama Huang <kamatogo13@gmail.com>
@fpetkovski
Copy link
Contributor

Thanks for the contribution. You can run make docs to fix the CI.

@kama910
fix the documentation error
bd511ae 
Signed-off-by: Kama Huang <kamatogo13@gmail.com>
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jan 12, 2023
@kama910
add change log
4487949 
Signed-off-by: Kama Huang <kamatogo13@gmail.com>
saswatamcode
saswatamcode approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@saswatamcode saswatamcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

yeya24
yeya24 approved these changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this LGTM!

@fpetkovski fpetkovski merged commit 02cda32 into thanos-io:main Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saswatamcode saswatamcode saswatamcode approved these changes

@yeya24 yeya24 yeya24 approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bucket tool: support other type of matchers in replicate
4 participants
@kama910 @fpetkovski @yeya24 @saswatamcode