Repair non-empty XOR chunks during 1h downsampling #6137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kartik-Garg
force-pushed
the
repair-xor-chunks
branch
from
c2e83eb
to
35eab83
Compare
Kartik-Garg
force-pushed
the
repair-xor-chunks
branch
3 times, most recently
from
fcc8622
to
e67d4d2
Compare
yeya24
reviewed
Feb 17, 2023
Kartik-Garg
force-pushed
the
repair-xor-chunks
branch
4 times, most recently
from
546ffc9
to
9a08e87
Compare
Kartik-Garg
changed the title
Kartik-Garg
force-pushed
the
repair-xor-chunks
branch
from
9a08e87
to
04f6bef
Compare
yeya24
reviewed
Feb 20, 2023
Kartik-Garg
force-pushed
the
repair-xor-chunks
branch
from
04f6bef
to
e2f16a9
Compare
yeya24
requested changes
Feb 20, 2023
Kartik-Garg
changed the title
Kartik-Garg
force-pushed
the
repair-xor-chunks
branch
from
e2f16a9
to
6b07303
Compare
Kartik-Garg
force-pushed
the
repair-xor-chunks
branch
from
6b07303
to
baff396
Compare
Kartik-Garg
changed the title
yeya24
reviewed
Feb 22, 2023
Iterated through the non empty XOR chunks, stored the results in a buffer and then downsampled them to 5m aggregated chunks by using DownsampleRaw method and then passed them for 1h downsampling. Signed-off-by: Kartik-Garg <kartik.garg@infracloud.io>
Kartik-Garg
force-pushed
the
repair-xor-chunks
branch
from
baff396
to
bfe2088
Compare
Added few more test cases to check if the data being downsampled gets converted to aggregated and also a test case to check if non-empty XOR chunks can be iterated through. Made changes in the test cases. Signed-off-by: Kartik-Garg <kartik.garg@infracloud.io>
Kartik-Garg
force-pushed
the
repair-xor-chunks
branch
from
bfe2088
to
6fc86a5
Compare
@yeya24 Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5482
Changes
Iterated through the non empty XOR chunks, stored the results in a buffer and then downsampled them to 5m aggregated chunks by using DownsampleRaw method and then passed them for 1h downsampling.
Verification
E2E and unit tests are passing.