Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert grpc-server-max-connection-age default value #6243

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Revert grpc-server-max-connection-age default value #6243

merged 1 commit into from
Mar 29, 2023

Conversation

pavdmyt
Copy link
Contributor

@pavdmyt pavdmyt commented Mar 27, 2023

Set --grpc-server-max-connection-age back to 60m by default, to avoid having infinitely open hanging connections.
Change was introduced in #6187

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

  • Set --grpc-server-max-connection-age back to 60m by default.

Verification

@pavdmyt
Revert grpc-server-max-connection-age default value
6b0930e 
Set --grpc-server-max-connection-age back to 60m by default, to avoid
having infinitely open hanging connections.

Signed-off-by: Pavel Dmytrenko <pavdmyt@aiven.io>
philipgough
philipgough approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@philipgough philipgough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

fpetkovski
fpetkovski approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@fpetkovski fpetkovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙇‍♀️

saswatamcode
saswatamcode approved these changes Mar 29, 2023
View reviewed changes
Copy link
Member

@saswatamcode saswatamcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fpetkovski
Copy link
Contributor

Let's merge this, the CircleCI failure seems to be a recurring one.

@fpetkovski fpetkovski merged commit d0c8275 into thanos-io:main Mar 29, 2023
@pavdmyt pavdmyt deleted the pavdmyt/revert-grpc-server-max-conn-age branch March 29, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saswatamcode saswatamcode saswatamcode approved these changes

@philipgough philipgough philipgough approved these changes

@fpetkovski fpetkovski fpetkovski approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pavdmyt @fpetkovski @philipgough @saswatamcode