Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: query path tenancy #6320

Merged
merged 25 commits into from
May 30, 2023
Merged

Proposal: query path tenancy #6320

merged 25 commits into from
May 30, 2023

Commits on Apr 26, 2023

  1. Add 1st version of query path tenancy proposal 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    2b86f4b View commit details
    Browse the repository at this point in the history

  2. Update proposal after initial feedback 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    8a9ffa3 View commit details
    Browse the repository at this point in the history

  3. Add cool picture 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    38c85c1 View commit details
    Browse the repository at this point in the history

  4. Include example in cross tenant query complications 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    2873c12 View commit details
    Browse the repository at this point in the history

  5. Improve reasoning for why not using the QFE 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    d68586b View commit details
    Browse the repository at this point in the history

  6. Improve writing in "How" section 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    908accb View commit details
    Browse the repository at this point in the history

  7. Fix owner profile link 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    52c865e View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Saswata Mukherjee <saswataminsta@yahoo.com>
Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata @saswatamcode
    douglascamata and saswatamcode authored Apr 27, 2023
    Configuration menu
    Copy the full SHA
    dc9b64b View commit details
    Browse the repository at this point in the history

  2. Address few more PR review comments 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    aa8f20a View commit details
    Browse the repository at this point in the history

  3. Address feedback on flag name text 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    ec47877 View commit details
    Browse the repository at this point in the history

  4. Update diagram 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    b14982c View commit details
    Browse the repository at this point in the history

  5. Improve non-goals text 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    1ba8493 View commit details
    Browse the repository at this point in the history

  6. Update diagram 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    abc44d8 View commit details
    Browse the repository at this point in the history

  7. Update docs/proposals-accepted/202304-query-path-tenancy.md 

    Co-authored-by: Filip Petkovski <filip.petkovsky@gmail.com>
Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata @fpetkovski
    douglascamata and fpetkovski authored Apr 27, 2023
    Configuration menu
    Copy the full SHA
    d325493 View commit details
    Browse the repository at this point in the history

  8. Clarify scenario for pitfalls of current solution 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    f7d1dc0 View commit details
    Browse the repository at this point in the history

  9. Clarify that Store doesn't care about tenant label 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    5e12994 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2023

  1. Add an action plan 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    c95450e View commit details
    Browse the repository at this point in the history

  2. Mention alternative idea of modifying Store API 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    c2e5f0e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' of github.com:thanos-io/thanos into query-path-te… 

    …nancy-proposal
    @douglascamata
    douglascamata committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    e9a6fa2 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2023

  1. Fix typo 

    Co-authored-by: Giedrius Statkevičius <giedriuswork@gmail.com>
Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata @GiedriusS
    douglascamata and GiedriusS authored May 4, 2023
    Configuration menu
    Copy the full SHA
    cf71fb6 View commit details
    Browse the repository at this point in the history

  2. Address lots of feedback on the proposal 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed May 4, 2023
    Configuration menu
    Copy the full SHA
    0001b62 View commit details
    Browse the repository at this point in the history

  3. Format query path tenancy proposal doc 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed May 4, 2023
    Configuration menu
    Copy the full SHA
    cd34490 View commit details
    Browse the repository at this point in the history

  4. Add a "Tenancy Model" subsection to "Goals" 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed May 4, 2023
    Configuration menu
    Copy the full SHA
    98b902b View commit details
    Browse the repository at this point in the history

  5. Mention header semanthics in comparison with gRPC message field 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed May 4, 2023
    Configuration menu
    Copy the full SHA
    f80384e View commit details
    Browse the repository at this point in the history

Commits on May 5, 2023

  1. Improve action plan structure and writing 

    Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
    @douglascamata
    douglascamata committed May 5, 2023
    Configuration menu
    Copy the full SHA
    300ed71 View commit details
    Browse the repository at this point in the history