Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blog: Fix images for LFX post #6422

Merged
merged 2 commits into from
Jun 7, 2023
Merged

blog: Fix images for LFX post #6422

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d015704
blog: Fix images for LFX post
saswatamcode Jun 7, 2023
d0178c5
fix lint
saswatamcode Jun 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions docs/blog/2023-06-02-lfx-mentorship-query-observability.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,15 +34,15 @@ Thanos needs to specify which engine to utilize to execute the promql queries. A

Here is the sketch of how the engine switch should look (made by Giedrius):

![Giedrius's Sketch](img/giedrius-sketch.png)
<img src="img/giedrius-sketch.png" alt="Giedrius&#39;s Sketch" width="800"/>

I looked into Thanos and made changes in Thanos components from the API to the UI to implement this engine switch. I tried to make the UI as close as possible to the sketch.

![Engine Switch 1](img/engine-1.png)
<img src="img/engine-1.png" alt="Engine Switch 1" width="800"/>

After initial review, I move this switch to each panel. As this helps to run the same query over the different engines and compare the results.

![Engine Switch 2](img/engine-2.png)
<img src="img/engine-2.png" alt="Engine Switch 2" width="800"/>

**Pull Requests**
- Add engine param to Thanos engine constructor ([thanos-io/promql-engine#228](https://github.com/thanos-io/promql-engine/pull/228))
Expand All @@ -56,11 +56,11 @@ I started with generating query explanations through the Thanos promql-engine an

Thanos UI got updated with time, resulting in the development of the explanation tree that can be seen through the screenshots provided.

![Tree 1](img/tree-1.png)
<img src="img/tree-1.png" alt="Tree 1" width="800"/>

![Tree 2](img/tree-2.png)
<img src="img/tree-2.png" alt="Tree 2" width="800"/>

![Tree 3](img/tree-3.png)
<img src="img/tree-3.png" alt="Tree 3" width="800"/>

**Pull Requests**
- Add method to explain query vector ([thanos-io/promql-engine#252](https://github.com/thanos-io/promql-engine/pull/252))
Expand Down