Update prometheus and promql-engine dependencies #7558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harry671003
force-pushed
the
update_prometheus
branch
4 times, most recently
from
058fc8f to
ee23000
Compare
saswatamcode
previously approved these changes
Jul 20, 2024
There was a problem hiding this comment.
LGTM but I think there were some unresolved comments in previous bump PR #7517 (comment) cc: @fpetkovski
harry671003
force-pushed
the
update_prometheus
branch
from
ee23000 to
0608899
Compare
harry671003
commented
Jul 20, 2024
| @@ -373,11 +374,6 @@ func Test_evaluateAtModifier(t *testing.T) { | |||
| [2m:]) | |||
| [10m:])`, | |||
| }, | |||
| { | |||
| // parse error: missing unit character in duration | |||
There was a problem hiding this comment.
Signed-off-by: 🌲 Harry 🌊 John 🏔 <johrry@amazon.com>
harry671003
force-pushed
the
update_prometheus
branch
from
0608899 to
8b87710
Compare
fpetkovski
approved these changes
Jul 22, 2024
2 tasks
jnyi
pushed a commit
to jnyi/thanos
that referenced
this pull request
Oct 17, 2024
Signed-off-by: 🌲 Harry 🌊 John 🏔 <johrry@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Verification
Depends on