Use iterators for in-process Series calls #7796
Merged
+400
−338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpetkovski
force-pushed
the
series-iterator
branch
3 times, most recently
from
ea5fe01 to
3dc7b18
Compare
The TSDBStore has two implementations of Series. One uses a goroutine and the other one buffers series in memory. Both are used for different use cases and trade-off CPU and memory according to the use. In order to reconcile these two approaches, we can use an iterator which relies on coroutines that have a much lower overhead than goroutines. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
fpetkovski
force-pushed
the
series-iterator
branch
3 times, most recently
from
5c463da to
6e07c71
Compare
| go 1.22.0 | ||
|
|
||
| toolchain go1.22.5 | ||
| go 1.23.0 |
There was a problem hiding this comment.
should we maybe bundle this on a separate PR? This interferes with build, maybe we should bump to 1.23 all in one pass.
There was a problem hiding this comment.
Technically we don't need to bump the version in go.mod because that indicates the minimum required version. If we do a bump without using new features, it means that downstream users are also forced to update their version even though there's no reason for that.
|
The goroutine leak seems to be legit, let me take a deeper look. |
fpetkovski
force-pushed
the
series-iterator
branch
from
6e07c71 to
2958a8c
Compare
Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
fpetkovski
force-pushed
the
series-iterator
branch
from
2958a8c to
1eaf6b0
Compare
|
The build and all tests should be passing now. |
pedro-stanaka
approved these changes
Oct 10, 2024
|
Doc failure is u related |
jnyi
pushed a commit
to jnyi/thanos
that referenced
this pull request
Oct 17, 2024
* Use iterators for in-process Series calls The TSDBStore has two implementations of Series. One uses a goroutine and the other one buffers series in memory. Both are used for different use cases and trade-off CPU and memory according to the use. In order to reconcile these two approaches, we can use an iterator which relies on coroutines that have a much lower overhead than goroutines. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> * Update golangci-lint Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> * Fix lint Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> --------- Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TSDBStore has two implementations of Series. One uses a goroutine and the other one buffers series in memory. Both are used for different use cases and trade-off CPU and memory according to the use.
In order to reconcile these two approaches, we can use an iterator which relies on coroutines that have a much lower overhead than goroutines.
Changes
Verification