*: bump deps + enable compaction randomization #7813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump go.mod dependencies of prometheus and thanos promql-engine. Enable randomized compaction start to help with reducing latency with multiple TSDBs. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
GiedriusS
force-pushed
the
bump_prom_deps_engine
branch
from
25848e9 to
aee5fbe
Compare
fpetkovski
reviewed
Oct 11, 2024
| {T: 1587690300000, F: 13.652631578947368}, {T: 1587690400000, F: 14.049122807017543}, {T: 1587690500000, F: 13.961403508771928}, {T: 1587690600000, F: 13.617543859649121}, {T: 1587690700000, F: 14.568421052631578}, {T: 1587690800000, F: 14.989473684210525}, | ||
| {T: 1587690900000, F: 16.2}, {T: 1587691000000, F: 16.052631578947366}, {T: 1587691100000, F: 15.831578947368419}, {T: 1587691200000, F: 15.659649122807016}, {T: 1587691300000, F: 14.842105263157894}, {T: 1587691400000, F: 14.003508771929823}, | ||
| {T: 1587691500000, F: 13.782456140350876}, {T: 1587691600000, F: 13.86315789473684}, {T: 1587691700000, F: 15.270282598474376}, {T: 1587691800000, F: 14.343859649122805}, {T: 1587691900000, F: 13.975438596491227}, {T: 1587692000000, F: 13.399999999999999}, | ||
| {T: 1587692100000, F: 14.087719298245613}, {T: 1587692200000, F: 14.392982456140349}, {T: 1587692300000, F: 15.02456140350877}, {T: 1587692400000, F: 14.073684210526315}, {T: 1587692500000, F: 9.3772165751634}, {T: 1587692600000, F: 6.378947368421052}, | ||
| {T: 1587692700000, F: 8.19298245614035}, {T: 1587692800000, F: 11.91870302641626}, {T: 1587692900000, F: 13.75813610765101}, {T: 1587693000000, F: 13.087719298245613}, {T: 1587693100000, F: 13.466666666666665}, {T: 1587693200000, F: 14.028070175438595}, | ||
| {T: 1587693300000, F: 14.23859649122807}, {T: 1587693400000, F: 15.407017543859647}, {T: 1587693500000, F: 15.915789473684208}, {T: 1587693600000, F: 15.712280701754384}, | ||
| }}, | ||
| {Metric: expectedLset2, Floats: []promql.FPoint{ | ||
| {DropName: true, Metric: expectedLset2, Floats: []promql.FPoint{ |
There was a problem hiding this comment.
Is this another change in PromQL?
There was a problem hiding this comment.
Not yet, there's a feature flag. It's a small bool to indicate that __name__ must be dropped: prometheus/prometheus@e9e3d64#diff-ad2761bb162a2f12326b18f2714ef54f4cd476cfe3388f77b2b20c5ff82e4faaR1655. The feature flag makes it so that __name__ is dropped at the end of evaluation instead of during it
|
I think this change is significant enough to be added to changelog (the compaction randomization) |
fpetkovski
previously approved these changes
Oct 11, 2024
Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
|
Added a CHANGELOG item 😄 |
pedro-stanaka
approved these changes
Oct 11, 2024
3 tasks
jnyi
pushed a commit
to jnyi/thanos
that referenced
this pull request
Oct 17, 2024
* *: bump deps + enable compaction randomization Bump go.mod dependencies of prometheus and thanos promql-engine. Enable randomized compaction start to help with reducing latency with multiple TSDBs. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> * CHANGELOG: add item Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> * *: fix CI Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> --------- Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump go.mod dependencies of prometheus and thanos promql-engine. Enable randomized compaction start to help with reducing latency with multiple TSDBs.