Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidecar: use prometheus metrics for min timestamp #7820

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Sidecar: use prometheus metrics for min timestamp #7820

merged 1 commit into from
Nov 6, 2024

Conversation

MichaHoffmann
Copy link
Contributor

This PR makes sidecar read "minT" from prometheus metrics instead of the shipper. This has the benefit that it also works for sidecar deployments that do not upload blocks, so that they can be pruned by time range too.

@MichaHoffmann MichaHoffmann force-pushed the mhoffmann/use-prometheus-tsdb-lowest-timestamp-for-mintime-in-sidecar branch from 51c58f7 to 6cff6e2 Compare October 13, 2024 16:56
pedro-stanaka
pedro-stanaka approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@pedro-stanaka pedro-stanaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG - some typos though.

pkg/promclient/promclient.go Show resolved Hide resolved
GiedriusS
GiedriusS reviewed Oct 14, 2024
View reviewed changes
Copy link
Member

@GiedriusS GiedriusS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not http://localhost:9090/api/v1/status/tsdb? Should be much faster than gathering all metrics and then parsing them not to mention the overhead of the PromQL engine.

@MichaHoffmann
Copy link
Contributor Author

Why not http://localhost:9090/api/v1/status/tsdb? Should be much faster than gathering all metrics and then parsing them not to mention the overhead of the PromQL engine

It doesn't have this data for whole tsdb. Only for head

GiedriusS
GiedriusS reviewed Oct 14, 2024
View reviewed changes
cmd/thanos/sidecar.go Outdated Show resolved Hide resolved
@MichaHoffmann
Sidecar: use prometheus metrics for min timestamp
c4d1de9 
Read "minT" from prometheus metrics so that we also set it for sidecars
that are not uploading blocks.

Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>
@MichaHoffmann MichaHoffmann force-pushed the mhoffmann/use-prometheus-tsdb-lowest-timestamp-for-mintime-in-sidecar branch from 6cff6e2 to c4d1de9 Compare October 16, 2024 16:30
@GiedriusS GiedriusS merged commit 761487c into main Nov 6, 2024
22 checks passed
@GiedriusS GiedriusS deleted the mhoffmann/use-prometheus-tsdb-lowest-timestamp-for-mintime-in-sidecar branch November 6, 2024 13:00
@BrewTestBot BrewTestBot mentioned this pull request Nov 25, 2024
Merged
@MichaHoffmann MichaHoffmann mentioned this pull request Nov 29, 2024
Closed
@ahurtaud ahurtaud mentioned this pull request Jan 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiedriusS GiedriusS GiedriusS approved these changes

@pedro-stanaka pedro-stanaka Awaiting requested review from pedro-stanaka

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaHoffmann @GiedriusS @pedro-stanaka