Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify Thanos Query Get Stores #926

Merged
merged 1 commit into from
Mar 15, 2019
Merged

Simplify Thanos Query Get Stores #926

merged 1 commit into from
Mar 15, 2019

Conversation

povilasv
Copy link
Member

@povilasv povilasv commented Mar 15, 2019 •
edited
Loading

We have created an interface which takes context and returns errors, although actual implementation never does that.

So simplifying code :)

bwplotka
bwplotka approved these changes Mar 15, 2019
View reviewed changes
Copy link
Member

@bwplotka bwplotka left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel sad as having error & context is a good idea for future, BUT as long as YAGNI states... fully agree with this change ((: LGTM.

@bwplotka bwplotka merged commit 51ff267 into thanos-io:master Mar 15, 2019
@povilasv povilasv deleted the simplify-get-stores branch March 15, 2019 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwplotka bwplotka bwplotka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@povilasv @bwplotka