Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make config reloader file writes atomic #962

Merged
merged 2 commits into from
Mar 22, 2019
Merged

Make config reloader file writes atomic #962

merged 2 commits into from
Mar 22, 2019

Commits on Mar 22, 2019

  1. Make config reloader file writes atomic 

    This addresses an issue found in the Prometheus Operator, which reuses
this reloader sidecar, but which then also has a second sidecar which
may trigger rule-based reloads while the config sidecar is in the middle
of writing out its config (in a non-atomic way):

prometheus-operator/prometheus-operator#2501

I didn't add a test for this because it's hard to catch the original
problem to begin with, but it has happened.

Signed-off-by: Julius Volz <julius.volz@gmail.com>
    @juliusv
    juliusv committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    67ea424 View commit details
    Browse the repository at this point in the history

  2. Explicitly ignore os.Remove() error 

    Signed-off-by: Julius Volz <julius.volz@gmail.com>
    @juliusv
    juliusv committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    3844bd4 View commit details
    Browse the repository at this point in the history