Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*:Fix version info after change to go mods. #991

Merged
merged 1 commit into from
Mar 28, 2019
Merged

*:Fix version info after change to go mods. #991

merged 1 commit into from
Mar 28, 2019

Conversation

jdfalk
Copy link
Contributor

@jdfalk jdfalk commented Mar 28, 2019 •
edited
Loading

Changes

Removed {{repoPath}}/vendor/ from .promu so that version info correctly populates after transition to go mods.

Verification

Build info is now correctly populated:

thanos, version 0.3.2-master (branch: master, revision: 57a58a75254d60be5fdb74cb63ceff829318117c)
  build user:       jdfalk@mm1
  build date:       20190328-15:08:32
  go version:       go1.12.1

adrien-f
adrien-f approved these changes Mar 28, 2019
View reviewed changes
Copy link
Member

@adrien-f adrien-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome ! Thanks a lot 😄

bwplotka
bwplotka approved these changes Mar 28, 2019
View reviewed changes
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉
thanks!

@bwplotka bwplotka merged commit 7a83cda into thanos-io:master Mar 28, 2019
@jdfalk jdfalk deleted the fix_version_info branch March 28, 2019 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwplotka bwplotka bwplotka approved these changes

@adrien-f adrien-f adrien-f approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdfalk @adrien-f @bwplotka