Update vgg19.py #17
Closed
Update vgg19.py #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @jeffin07, thanks for the effort! I'll do a quick review when I get time and then update on this. |
|
Hey, sorry for the late response. I've now mentioned this PR in the known issues section in the README file (link). I have decided not to merge this for now since I have not recommended an exact NumPy version to the users. In the known issues section linked above, I have asked users who would like to use a higher version of NumPy (which may have this issue) to check this PR out to see how they can fix the issue manually. Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have changed the vgg19.py,legacy/vgg19small.py files. In the init method of Vgg19 class, I have added
allow_pickle=Truetonp.load()function so that errors like in #7 Can be solved as everyone try to load the model with the given weights