Convert rule.pp from class to define so we can instantiate it multiple times

[forgodssake]

Hi,

With this change you can add specific rules to every case (webserver, database, monitoring, ...) rather than bit lists of nearly the same rules for every role.

[vegetableZucchini]

Hello hathoward and forgodssake I have 2 questions.
First, @hathoward why would this change not be committed if it's providing a real benefit to the module and thus the Puppet community that consumes on it?
Second, @forgodssake I am confused by the use of $rule_key in the init.pp file and then $title in the rule.pp file. Would you be so kind to provide examples?

Thank you.

[thatrevguy]

His PR is probably fine, just have not made time to provide unit and integration tests to properly maintain this module. If I were to commit time to this module again I'd rather contribute it to the official puppet firewall module by adding a windows FW provider that implements/extends their type. Motivation for the above has been lacking due to my professional time now being consumed by Linux based solutions.

[vegetableZucchini]

Good day @hathoward I appreciate your time to reply. I too wish the official puppet/windows_firewall forge module was better performing however it lacks the basic functionality to maintain and enforce state of the Windows firewall.
Such as:
When you try to enable the firewall, it does not enable all the profiles. ie. the domain profile.
When a rule with the same name already exists, it has no affect. So when you want to change an existing rule, this will not work.
When ensure => absent is used, it gives error and does not work correctly.
So this module is good only to add new rules.

As you mentioned you are very busy, if you do find free time could you provide a simple example of what @forgodssake is doing with $title is it referencing the $title of the hiera manifest name?

Thank you and have a great day!