Fix bug with milliseconds precision #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aurelien-baudet
approved these changes
Nov 4, 2021
|
Thank you for your contribution |
|
Shouldn't Created this pr to address the issue 👉 #8. |
samirergaibi
added a commit
to samirergaibi/workflow-dispatch
that referenced
this pull request
Dec 27, 2022
remove ms precision from `triggerDate` as was the meaning of this previous bug fix the-actions-org#4
aurelien-baudet
pushed a commit
that referenced
this pull request
Jun 8, 2023
* bugfix: remove ms precision from `triggerDate` remove ms precision from `triggerDate` as was the meaning of this previous bug fix #4 * remove redundant Date.now
MatthewRyanRead
added a commit
to RentTheRunway/workflow-dispatch
that referenced
this pull request
Jun 9, 2023
* Update to node16 (the-actions-org#7) * Update to Node 16 to address GH warnings * Update to node 16 on build * Update dependency actions to Node 16 support * Update to deps using Node 16 * bugfix: remove ms precision from `triggerDate` (the-actions-org#8) * bugfix: remove ms precision from `triggerDate` remove ms precision from `triggerDate` as was the meaning of this previous bug fix the-actions-org#4 * remove redundant Date.now * Provide run name optional parameter to fetch run id based on name (the-actions-org#6) * use check listforref to obtain run id * proper param for run name * Automated publish: Thu Jun 8 06:14:15 UTC 2023 d0f84d4 * chore(pr): Some adjustments after merge of PRs * Automated publish: Thu Jun 8 07:01:06 UTC 2023 928e175 * feat(logs): Retrieve and print logs of triggered workflow Upgrade all dependencies * chore(logs): Prefix imported logs * Automated publish: Fri Jun 9 06:55:17 UTC 2023 46e0c62 --------- Co-authored-by: Rui Ferreira <rui-ferreira@users.noreply.github.com> Co-authored-by: Samir Ergaibi <38135462+samirergaibi@users.noreply.github.com> Co-authored-by: Robbert van der Gugten <robbertvdg@gmail.com> Co-authored-by: Automated Publisher <actions@users.noreply.github.com> Co-authored-by: Aurélien Baudet <Aurelien.baudet@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workflow runs that GitHub API returns don't have millisecond precision.
So there might be a situation that the trigger date is:
"2021-10-08T18:42:45.031Z"while the corresponding run that GitHub API might returncreated_at = "2021-10-08T18:42:45Z"(if everything happened in less than a second).That causes this action to fail by timeout (after trying to find run many times).
(There might be another solution where we use
dateheader of GitHub response after create workflow dispatch)