Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add go1.22 "net/http" package’s router #7572

Merged
merged 3 commits into from
Jul 3, 2024
Merged

Add go1.22 "net/http" package’s router #7572

merged 3 commits into from
Jul 3, 2024

Conversation

xuyang2
Copy link
Contributor

@xuyang2 xuyang2 commented Jul 2, 2024 •
edited
Loading

@xuyang2 xuyang2 requested a review from waghanza as a code owner July 2, 2024 12:42
@xuyang2 xuyang2 changed the title Add go1.22 "net/http" package’s router #7571 Add go1.22 "net/http" package’s router Jul 2, 2024
waghanza
waghanza reviewed Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@waghanza waghanza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Ths could be a reference for go frameworks that use net/http 🎉

go/nethttp/go.mod Outdated Show resolved Hide resolved
go/nethttp/config.yaml Show resolved Hide resolved
go/nethttp/config.yaml Outdated Show resolved Hide resolved
@xuyang2 @waghanza
Apply suggestions from code review
8a310be 
Co-authored-by: Marwan Rabbâa <waghanza@gmail.com>
@xuyang2 xuyang2 force-pushed the go-net-http branch 2 times, most recently from d444c0a to b7cfe41 Compare July 2, 2024 14:45
@waghanza waghanza merged commit de39c10 into the-benchmarker:master Jul 3, 2024
2 checks passed
@xuyang2 xuyang2 deleted the go-net-http branch July 3, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waghanza waghanza waghanza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xuyang2 @waghanza