-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #16: Create Team Component and Loading Screen #46
Conversation
Visit the preview URL for this PR (updated for commit cc1e08d): https://tcl-74-smart-shopping-list--pr46-dtp-teampage-11gp9tx9.web.app (expires Mon, 14 Oct 2024 16:38:36 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 79d73546692f99aad8468c28e36db434e2c190ac |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! photo links are broken in the preview, but this might just be an issue with the preview? very nice work regardless!
Thank you, Nick! The links are working. I apologize for adding the screenshot after your approval, but I wanted to ensure you could see how it looks locally. |
17. implement toast notifications on all messages not requiring user input
…cy developer image. Implement conditional rendering for dev portfolio. Update useAuth and SignIn is not navigating to home from developer page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Great work!
Description
I have created a new Team.jsx component that showcases our developers (developer order can be changed and content was gathered from https://the-collab-lab.codes/developers/). This component includes:
Additionally, I implemented a Loading component that utilizes React's Suspense. The Suspense component is used to wrap the Team component, allowing for a fallback UI while the Team component is being loaded asynchronously. This fallback UI displays the Loading component (logo) until the main content is ready to be displayed.
Navigation Update (WIP):
Update the useAuth hook to navigate to the home page once the user signs in from the developers page.
Related Issue
Closes #45
Acceptance Criteria
Type of Changes
Enhancement
Bug Fix
Updates
After
Testing Steps / QA Criteria