Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #16: Create Team Component and Loading Screen #46

Merged
merged 13 commits into from
Oct 7, 2024

Conversation

dterceroparker
Copy link
Member

@dterceroparker dterceroparker commented Oct 3, 2024

Description

I have created a new Team.jsx component that showcases our developers (developer order can be changed and content was gathered from https://the-collab-lab.codes/developers/). This component includes:

  • Developer photos
  • Names
  • Links to GitHub, LinkedIn, and personal portfolios

Additionally, I implemented a Loading component that utilizes React's Suspense. The Suspense component is used to wrap the Team component, allowing for a fallback UI while the Team component is being loaded asynchronously. This fallback UI displays the Loading component (logo) until the main content is ready to be displayed.

Navigation Update (WIP):

Update the useAuth hook to navigate to the home page once the user signs in from the developers page.

Related Issue

Closes #45

Acceptance Criteria

Type of Changes

Enhancement
Bug Fix

Updates

After

Screen Shot 2024-10-05 at 2 59 49 PM

Testing Steps / QA Criteria

  • Access the Developer page from the Landing page (while signed out).
  • After signing in, the Developer page should automatically navigate to the Home page.
  • Note: Images will not display in the preview; please refer to the PR screenshot for visual reference.

Copy link

github-actions bot commented Oct 3, 2024

Visit the preview URL for this PR (updated for commit cc1e08d):

https://tcl-74-smart-shopping-list--pr46-dtp-teampage-11gp9tx9.web.app

(expires Mon, 14 Oct 2024 16:38:36 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 79d73546692f99aad8468c28e36db434e2c190ac

@dterceroparker dterceroparker changed the title Issue #16: create Team component Issue #16: Create Team Component and Loading Screen Oct 3, 2024
@dterceroparker dterceroparker self-assigned this Oct 3, 2024
Copy link
Collaborator

@NickRoccodev11 NickRoccodev11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! photo links are broken in the preview, but this might just be an issue with the preview? very nice work regardless!

@dterceroparker
Copy link
Member Author

looks great! photo links are broken in the preview, but this might just be an issue with the preview? very nice work regardless!

Thank you, Nick! The links are working. I apologize for adding the screenshot after your approval, but I wanted to ensure you could see how it looks locally.

NickRoccodev11 and others added 3 commits October 5, 2024 14:06
17. implement toast notifications on all messages not requiring user input
…cy developer image. Implement conditional rendering for dev portfolio. Update useAuth and SignIn is not navigating to home from developer page
@dterceroparker dterceroparker marked this pull request as ready for review October 5, 2024 19:33
Copy link
Collaborator

@shuveksha-tuladhar shuveksha-tuladhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Great work!

@dterceroparker dterceroparker merged commit ad8958c into main Oct 7, 2024
2 checks passed
@dterceroparker dterceroparker deleted the dtp-teampage branch October 7, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

16 Create Team Component and Loading Screen
4 participants